Skip to content

Added capability to export to portable pixmap#549

Merged
cameronwhite merged 15 commits into
PintaProject:masterfrom
Lehonti:feature/netpbm_export
Oct 11, 2023
Merged

Added capability to export to portable pixmap#549
cameronwhite merged 15 commits into
PintaProject:masterfrom
Lehonti:feature/netpbm_export

Conversation

@Lehonti
Copy link
Copy Markdown
Contributor

@Lehonti Lehonti commented Oct 4, 2023

No description provided.

@cameronwhite
Copy link
Copy Markdown
Member

Looks good to me, thanks!
How about also adding a unit test for this? :) Since it's a text-based format, comparing some small image against the expected result probably would probably work

@Lehonti
Copy link
Copy Markdown
Contributor Author

Lehonti commented Oct 6, 2023

Sure, here's an attempt, but I don't know if it works, because my Ubuntu enviroment can't find GLib (and apparently neither can the GitHub checks), and I haven't had the time to find out why.

In my opinion, though, if properly testing this becomes too daunting, the testing could be left for later.

@cameronwhite
Copy link
Copy Markdown
Member

I haven't looked in depth, but you may need to call the Module.Initialize() functions somewhere in Pinta.Core.Tests at startup, similar to https://github.com/PintaProject/Pinta/blob/master/tests/Pinta.Effects.Tests/Utilities.cs#L11 in the effects tests. Right now I only see the text engine test doing this for Pango

@Lehonti
Copy link
Copy Markdown
Contributor Author

Lehonti commented Oct 10, 2023

Apparently, that's exactly what was needed. The tests are now running and passing as expected

@cameronwhite
Copy link
Copy Markdown
Member

Looks good, thanks!

@cameronwhite cameronwhite merged commit 441becd into PintaProject:master Oct 11, 2023
@Lehonti Lehonti deleted the feature/netpbm_export branch October 11, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants