Skip to content

Add Unit Tests for GetDateTest.cs and StartSleepTest.cs#775

Merged
andyleejordan merged 5 commits into
masterfrom
UnitTest_Temp
Apr 8, 2016
Merged

Add Unit Tests for GetDateTest.cs and StartSleepTest.cs#775
andyleejordan merged 5 commits into
masterfrom
UnitTest_Temp

Conversation

@TingLiu6

@TingLiu6 TingLiu6 commented Apr 6, 2016

Copy link
Copy Markdown
Contributor

Please help to review, thanks!


This change is Reviewable

@TingLiu6

TingLiu6 commented Apr 7, 2016

Copy link
Copy Markdown
Contributor Author

@andschwa , could you please help to merge this to master, thanks.

@andyleejordan

Copy link
Copy Markdown
Member

@JamesWTruher Please review and merge.

Comment thread test/powershell/Get-Date.Tests.ps1 Outdated

It "using -displayhint produces the correct output" {
$newLine = [Environment]::NewLine
Get-date -Date:"Jan 1, 2020" -DisplayHint:$([Microsoft.PowerShell.Commands.DisplayHintType]::Date) | Out-String | Should be $newLine"Wednesday, January 1, 2020$newLine$newLine$newLine"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-DisplayHint:$([Microsoft.PowerShell.Commands.DisplayHintType]::Date)
should just be:
-DisplayHint Date
Also, I'd be happier if this was
$d = get-date -date "Jan 1, 2020" -DisplayHint Date | out-string
$d.Trim() | should be "Wednesday, January 1, 2020"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@andyleejordan

Copy link
Copy Markdown
Member

LGTM.

@andyleejordan andyleejordan merged commit a5966a8 into master Apr 8, 2016
@andyleejordan andyleejordan deleted the UnitTest_Temp branch April 8, 2016 04:03
@ghost

ghost commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #10017, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

@ghost

ghost commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #9954, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

@ghost

ghost commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #9885, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

@ghost

ghost commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #9875, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

@ghost

ghost commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #9862, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

@ghost

ghost commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #9854, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

@ghost

ghost commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #9843, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

@ghost

ghost commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #9805, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

@ghost

ghost commented Aug 20, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #10364, which has now been successfully released as v7.0.0-preview.3.:tada:

Handy links:

@ghost

ghost commented Sep 19, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #10421, which has now been successfully released as v7.0.0-preview.4.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants