login with external ID#403
Merged
Merged
Conversation
This was referenced Nov 10, 2017
liujoshua
requested changes
Nov 10, 2017
liujoshua
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks great. One change request for consistency with ResearchKit constants
| @@ -57,6 +57,8 @@ public enum SurveyItemType { | |||
| ACCOUNT_EMAIL_VERIFICATION ("emailVerification" ), // EmailVerificationStep | |||
| @SerializedName("externalID") | |||
| ACCOUNT_EXTERNAL_ID ("externalID" ), // ExternalIDStep | |||
Collaborator
There was a problem hiding this comment.
ACCOUNT_EXTERNAL_ID, which currently produces a non-implemented step, is intended to support this feature. We should use this.
@dephillipsmichael, does that sound right?
See:
| @@ -690,8 +724,9 @@ public ProfileStep createProfileStep(Context context, ProfileSurveyItem item) { | |||
| * @param item InstructionSurveyItem from JSON | |||
Collaborator
There was a problem hiding this comment.
Please add @param loginOptions
| static { | ||
| List<ProfileInfoOption> tempList = new ArrayList<>(); | ||
| tempList.add(ProfileInfoOption.EXTERNAL_ID); | ||
| EXTERNAL_ID_LOGIN_OPTIONS = Collections.unmodifiableList(tempList); |
liujoshua
approved these changes
Nov 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding page for login with external ID.