host_env: os.mkdir for Windows, Redox#8128
Open
joshuamegnauth54 wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/host_env/src/posix_wasi.rs`:
- Around line 4-10: The make_dir function uses &Path as a parameter type, but
Path is not imported from the standard library, causing a compilation error. Add
path::Path to the existing std imports at the top of the file where ffi::OsStr
and io are already imported to bring Path into scope.
In `@crates/vm/src/stdlib/os.rs`:
- Line 191: The MKDIR_DIR_FD constant in the os.rs file is currently configured
only for unix systems using cfg!(unix), but since WASI now supports the optional
dir_fd parameter in make_dir function as implemented in posix_wasi.rs, the cfg
condition needs to be updated. Modify the MKDIR_DIR_FD constant definition to
also include WASI targets in the condition so that dir_fd functionality is
enabled on WASI systems where it is now supported.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 9e70d5e8-58e8-4b98-9525-1ee325ec8978
📒 Files selected for processing (3)
crates/host_env/src/posix.rscrates/host_env/src/posix_wasi.rscrates/vm/src/stdlib/os.rs
2d1b1cd to
eb71c5c
Compare
4ebd815 to
4150ef9
Compare
Python supports `mkdir` on Windows. I deferred to calling Rust's implementation for now. However, like `rename`, Python's implementation supports additional features that are currently unsupported on RustPython. I added a note for future reference. Redox supports `mkdirat` which significantly cleans up the implementation.
4150ef9 to
6935f14
Compare
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python supports
mkdiron Windows. I deferred to calling Rust's implementation for now. However, likerename, Python's implementation supports additional features that are currently unsupported on RustPython. I added a note for future reference.Redox supports
mkdiratwhich significantly cleans up the implementation.Summary
On a related note, I think the WASI Posix and Unix implementations can be combined eventually. 🤔
Summary by CodeRabbit