Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,8 @@ jobs:
skips: []
timeout: 60
- os: windows-2025
extra_test_args: [] # TODO: Enable '-u all'
extra_test_args:
- '-u all'
env_polluting_tests:
- test_set
skips: []
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_codecmaps_kr.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class TestCP949Map(multibytecodec_support.TestBase_Mapping,
encoding = 'cp949'
mapfileurl = 'http://www.pythontest.net/unicode/CP949.TXT'

@unittest.expectedFailure # TODO: RUSTPYTHON; LookupError: unknown encoding: cp949
@unittest.expectedFailureIf(__import__("sys").platform in ("android", "darwin", "linux"), "TODO: RUSTPYTHON; LookupError: unknown encoding: cp949")
def test_mapping_file(self):
return super().test_mapping_file()

Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_codecmaps_tw.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class TestCP950Map(multibytecodec_support.TestBase_Mapping,
(b"\xFFxy", "replace", "\ufffdxy"),
)

@unittest.expectedFailure # TODO: RUSTPYTHON; LookupError: unknown encoding: cp950
@unittest.expectedFailureIf(__import__("sys").platform in ("android", "darwin", "linux"), "TODO: RUSTPYTHON; LookupError: unknown encoding: cp950")
def test_errorhandle(self):
return super().test_errorhandle()

Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_tokenize.py
Original file line number Diff line number Diff line change
Expand Up @@ -2173,6 +2173,7 @@ def test_string_concatenation(self):
# Two string literals on the same line
self.check_roundtrip("'' ''")

@unittest.skipIf(support.is_resource_enabled("cpu") and __import__("sys").platform == "win32", "TODO: RUSTPYTHON; Timeout after 10 minutes")
def test_random_files(self):
# Test roundtrip on random python modules.
# pass the '-ucpu' option to process the full directory.
Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_venv.py
Original file line number Diff line number Diff line change
Expand Up @@ -1094,6 +1094,7 @@ def nicer_error(self):
f"**Subprocess Error**\n{err}"
)

@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON; FileNotFoundError: [WinError 2] No such file or directory")
@requires_venv_with_pip()
@requires_resource('cpu')
def test_with_pip(self):
Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_winconsoleio.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ def test_write_empty_data(self):
with ConIO('CONOUT$', 'w') as f:
self.assertEqual(f.write(b''), 0)

@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
@requires_resource('console')
def test_write(self):
testcases = []
Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_winsound.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ def test_keyword_args(self):

class PlaySoundTest(unittest.TestCase):

@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON; TypeError: a bytes-like object is required, not 'str'")
def test_errors(self):
self.assertRaises(TypeError, winsound.PlaySound)
self.assertRaises(TypeError, winsound.PlaySound, "bad", "bad")
Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_wmi.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ def test_wmi_query_not_select(self):
with self.assertRaises(ValueError):
wmi_exec_query("not select, just in case someone tries something")

@unittest.skipIf(__import__("sys").platform == "win32", "TODO: RUSTPYTHON; Timeout after 10 minutes")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wmi itself is windows-only test. skipIf is nonsense.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, my rational was that it will be easier to see at the diagnostics of how many tests do we skip on each platform, I can just skip it without any conditions

@support.requires_resource('cpu')
def test_wmi_query_overflow(self):
# Ensure very big queries fail
Expand Down
Loading