Fix for a2m -Wsign-compare#144
Merged
Merged
Conversation
src/a2m.cpp: In member function ‘virtual bool Ca2mLoader::load(const string&, const CFileProvider&)’:
src/a2m.cpp:162:17: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
162 | for (i = 0; i < length; i++)
src/a2m.cpp: In member function ‘virtual bool Ca2mLoader::load(const string&, const CFileProvider&)’:
src/a2m.cpp:203:20: warning: comparison of integer expressions of different signedness: ‘long int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
203 | if (orgptr - org < needed) {
Contributor
Author
|
There are more of these signed compare warnings, but probably makes sense to split them up into PRs, since some of them might need discussion? Or do you prefer to have them in a single PR? |
mywave82
commented
Dec 12, 2022
Member
Separate PRs for each would probably be better, because easier to review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/a2m.cpp: In member function ‘virtual bool Ca2mLoader::load(const string&, const CFileProvider&)’: src/a2m.cpp:162:17: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
162 | for (i = 0; i < length; i++)
src/a2m.cpp: In member function ‘virtual bool Ca2mLoader::load(const string&, const CFileProvider&)’:
src/a2m.cpp:203:20: warning: comparison of integer expressions of different signedness: ‘long int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
203 | if (orgptr - org < needed) {