Fix for d00-Wsign-compare#148
Merged
Merged
Conversation
src/d00.cpp: In member function ‘virtual void Cd00Player::rewind(int)’:
src/d00.cpp:465:15: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
465 | if (subsong < getsubsongs() && dataofs + sizeof(Stpoin) <= filesize)
| ~~~~~~~~^~~~~~~~~~~~~~~
Contributor
Author
|
Currently rewind() is prototyped with subsong being signed int, and only rix.cpp and d00.cpp actually has special handling for <0 value, while other subsong implementors does range checks and clamps the value to 0 if out of range. I assume the correct would be to fix other implementors to handle <0 as current song reload instead of clamping. |
Contributor
Author
|
Moved rewind() question into is own issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.