Fix for dro2-Wsign-compare and convert some additional variables from signed into unsigned #149
Merged
Merged
Conversation
…nstead of signed datatypes.
src/dro2.cpp: In member function ‘virtual bool Cdro2Player::load(const string&, const CFileProvider&)’:
src/dro2.cpp:69:27: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
69 | this->iLength > fp.filesize(f) - f->pos()) {
| ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
mywave82
commented
Dec 17, 2022
| return false; | ||
| } | ||
|
|
||
| this->iLength = f->readInt(4); // should better use an unsigned type |
Contributor
Author
There was a problem hiding this comment.
// should better use an unsigned type
Acknowledged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this warning and make some more of the logic work with unsigned instead of signed datatypes.