Updated Nuked to the latest master#172
Conversation
This removes necessity of editing the header for users, who might have their own Bit* types defined. Standard types are also usually recognized by syntax highlight, thus the code is a little bit more readable.
Without extern "C" block, C++ projects need to either rename the files to cpp or place the extern block around opl3.h include.
Allows compilation with -std=c89.
Co-authored-by: Evan Ramos <hendricks266@gmail.com>
…late the panning table
|
Not too keen on submodules myself, they are a bit of a messy hack. Probably neater to do a squash merge and list which upstream Nuked commit it is being updated to, as we don't really need the whole Nuked commit history repeated again in AdPlug. As long as the Nuked commit hash is present in the AdPlug commit message, it makes it easy for anyone to match it back to the Nuked git history if they wish. |
|
If I do a squash, I can add a list of all the hashes from the original project, and add url to where the original project is located. The hashes currently are unique for adplug since the commit messages are not 100% carbon copy, the original parent are ours, and the files are not 100% the same due to filename being altered. |
|
You probably don't need to list all the Nuked commit hashes, if you just write something like "Update to NukedOPL commit abc123" then that should be enough to know what point it's at. Knowing that hash is enough to go back through the NukedOPL history to see what changes were made if anyone ever needs to, since each commit hash includes a pointer to the parent commit. I don't think it's too important to worry about the AdPlug-specific changes. Anyone who wants to know that can just do a diff between the AdPlug file and the upstream one and that will show all of AdPlug's changes. |
Nuked OPL3 is up to date with https://github.com/nukeykt/Nuked-OPL3 f2c98738413f2711321d7a4b6e294d58ea2cdc6d --------- Co-authored-by: Patryk Obara <patryk.obara@gmail.com> Co-authored-by: Patryk Obara <dreamer.tan@gmail.com> Co-authored-by: nukeykt <alexeytf2@gmail.com> Co-authored-by: Evan Ramos <hendricks266@gmail.com> Co-authored-by: Kagamiin~ <kingchuxing.trills@aleeas.com>
Alternative we could use a git submodule?