last alternative would be to have a sub switch with different text?
"type 0 - single track"
"type 1 - multi track"
"type 2 - multi pattern"

I think, showing just 'Type 0' or 'Type 1' would be enough. Any other objections?

Type 2 files definitely exist although rare, so you'd need to be able to handle that too.

If you want to do it in a true cross-platform manner, in a way that will work regardless of which character set is in use, you'll probably have to use string streams.

I used this macro in Camoto, you are welcome to borrow it:

#include <sstream>
/**
 * String creation macro (with iostream syntax).
 * 
 * Useful for assigning strings in constructor initialisation lists.
 *
 * @code
 * std::string str = createString("The value is " << iValue);
 * @endcode
 */
#define createString(a) \
        (static_cast<const std::ostringstream&>(std::ostringstream() << a).str())

Then you would write:

return createString("General MIDI (type " << midi_type << ")");

It's probably only worth doing this though if there are a number of different places you can use it, across multiple files. It's probably overkill for just a single use.

Maybe a compromise that doesn't assume ASCII but also doesn't pull in stringstream would be std::string(1, '0' + midi_type) which doesn't hardcode '0' as 0x30 and thus is also a bit more understandable.

BTW, the readme still mentions that AdPlug is "currently tested" with GCC 4.1, which evidently cannot be true. Maybe that information should be removed...

tweak from @sagamusix is more readable, and with a comment perhaps about why we do it.

return std::string("General MIDI (type " + std::string(1, '0' + midi_type) + ")"); // avoid using std::to_string(midi_type) which is c++11 ```

I also added a issue about that testing currently does not test gcc 4.1, this detail probably has been missing since adplug was migrated to github

I've updated the PR as @mywave82 suggested.
If being more specific, std::to_string should be avoided not because it's c++11, but because its implementation was broken/missing for a long time specifically in mingw32, but later fixed in mingw64 only, afaik.

https://stackoverflow.com/questions/12975341/to-string-is-not-a-member-of-std-says-g-mingw

Thank you for the patience