Add DJGPP support to Adplug#193
Conversation
|
After some fiddling with GitHub actions I managed to add DJGPP compilation support. Build results are available in my fork: https://github.com/AranVink/adplug/actions/runs/6091183567 Please review and let me know what you think. I'm very sorry for the commit spam, I thought I was only pushing to my own repository while doing these tests, but unfortunately this PR and CI still got triggered through my own repo/branch. 😅 |
|
I am quite busy the next two weeks, but I will try to grab some time every now and and probably rebuild to commit history (doing some git rebase magic) |
|
Much appreciated, if you want me to make a new PR with all commits squashed let me know (I made this mess 😉) |
|
I rebased your tree, so unless you are very familier with git, just do a fresh clone of your own git repository on your computer. I believe a lot of the fiddling with setting CXXFLAGS etc. to include -I/foo/djgpp/include can be avoided if djgpp extracted into /usr/local/djgpp, as that is probably the PREFIX is was compiled for. |
|
I think some fixes from here could be already pushed to master, like header and type fixes. They are trivial. |
|
Thank you for revisiting this. I'll take another look this weekend on the CXXFLAGS/paths. Are there any other concerns or attention points that would prevent this from being merged in the near future? I'd like this PR to be as complete as possible, so I can continue with upgrading Adplay for DOS. |
|
We are getting close to something now (git rebase is needed again to clean up the history) |
This file is ONLY compiled if the system is lacking getopt.h (DJGPP is one example)
|
Sorry for the extra spam lately, trying to make the github workflow be a smooth as possible. |
…, since make install invokes ranlib which for DJGPP is not a global command.
|
Thank you for your patience |
|
Thank you for following up and making the tweaks so it can be merged, again much appreciated. I'll continue working on Adplay for DOS, building a CD pipeline, and maybe even a CI pipeline (when tooling allows). |
Add a few #ifdef preprocessor commands to check for DJGPP being used a compiler for DOS.
Prerequisite PR for PR on Adplay-DOS: adplug/adplay-dos#3