Add support for reheadered D00 songs#219
Merged
Merged
Conversation
Some old-style D00 songs were reheadered later on. These are identifiable via version numbers with bit 8 set. They can be read like old-style D00 songs by skipping the new header and jumping to the old one instead.
Contributor
|
We need to add a sample song into the test database :-) |
Contributor
|
@mistydemeo Testfile added looks OK? |
Contributor
Author
|
Yes, that testfile looks perfect - doesn't work in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some old-style D00 songs were reheadered later on. These are identifiable via version numbers with bit 8 set. They can be read like old-style D00 songs by skipping the new header and jumping to the old one instead.
I considered trying to get adplug to read the new-style header, but there's a couple other inconsistencies it wasn't happy with; it seemed easier just to use the old-style header. The Mac OS X EdLibPlay player does the same thing. If you're interested in some samples, the EdLibPlay download comes with a number of them. I used Laxity/The_Alibi.d00 as my sample song for this patch.