[IMF] Use correct delete syntax, and remove warnings seen in Appveyor Visual Studio 12 build.#232
Merged
Merged
Conversation
…Windows builds, and unsigned long always has enough space for our use-cases.
binarymaster
reviewed
Aug 5, 2024
|
|
||
| // file validation section | ||
| size_t hdr_size = 0; | ||
| unsigned long hdr_size = 0; |
Member
There was a problem hiding this comment.
What's wrong with using size_t? I always thought this unit is used for such cases
Member
There was a problem hiding this comment.
If it's mixed with unsigned long in other places, it's better to fix those.
Contributor
Author
There was a problem hiding this comment.
size_t is either a int or long, depending on compiler environment and defines before including lib-c header files, and is mostly only used by libc in the fileoperations; libbinio uses unsigned long, so no need to use size_t anyway in this use-case.
binarymaster
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.