[PLX] Coverity reported that fmregs was one byte too small and some attributes that could be used without being initialized.#238
Merged
Conversation
…ttributes that could be used without being initialized. Also improved formatting of opl2_init_regs[] definition.
Contributor
Author
|
Regarding rewind(): Any entries in opl2_init_regs that are zero, will not be set during initialization calls to set_regs due to memset(fmchip, 0, sizeof(fmchip)); Perhaps setregs should had an alternative version that is write-through no matter what previously is stored in fmchip[], and remove the memset in rewind(). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also improved formatting of opl2_init_regs[] definition.
Avoid possible division by zero in getrefresh()