Add mingw-w64 CI build, fix dir delimeter for win32 in tests/mus.cpp#270
Merged
Conversation
binarymaster
left a comment
Member
There was a problem hiding this comment.
Yes, in mus.cpp I was attempting to support both slashes for path separation.
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
binarymaster
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds mingw-w64 to the CI build
To get it to work, some tests had to be changed so they use the right path separator (dir delimeter), as well as a minor fix in
mus.cpp@dmitrysmagin I noticed you made some recent additions for MinGW as well, hope our work doesn't overlap (was happy to see you fixed some tests which I was in the process of tackling myself as well)
@binarymaster Please double-check the
mus.cppmodifications if you are able. If I read to code correctly the bank loading first tries it with/from the path, then with\\if none is found, which to me suggested this was an attempt to split string on path. I guess under most conditions this worked fine so far, but when doing a hybridmake checktest from Linux, calling the tests underwine64this code broke in a weird way. Using a predefined delimiter fixed the issue for mingw (and kept other builds green).