chore: update shared eslint config to a stable version#579
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the shared ESLint configuration to a stable version and changes various module import paths to use the "node:" prefix for improved clarity and compatibility.
- Updated the ESLint config import from the generic to the TypeScript-specific config.
- Updated module imports to use Node.js’s new "node:" specifiers in several source files.
- Adjusted import paths in CI-related scripts and server-related files.
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eslint.config.mjs | Updated the ESLint config import to reference a TypeScript-specific file |
| src/socket.ts | Changed module import paths from 'net' and 'tls' to 'node:net' and 'node:tls' |
| src/utils/count_target_bytes.ts | Changed module import and added an eslint-disable comment in a helper function |
| src/statuses.ts | Updated import path for http’s STATUS_CODES |
| src/tcp_tunnel_tools.ts | Updated module imports for net and URL |
| src/utils/get_basic.ts | Updated URL import path |
| src/custom_response.ts | Updated imports for Buffer and http |
| src/forward_socks.ts | Updated module imports for http, stream, URL, and util |
| src/chain.ts | Updated module imports for Buffer, dns, events, http, https, and URL |
| .github/scripts/before-beta-release.js | Updated module imports to use "node:" for child_process, fs, and path |
| src/forward.ts | Updated module imports for dns, http, https, stream, URL, and util |
| src/server.ts | Updated module imports for Buffer, dns, events, http, net, URL, and util |
| src/direct.ts | Updated module imports for Buffer, dns, events, net, and URL |
| src/chain_socks.ts | Updated module imports for Buffer, events, http, net, and URL, reordered import from socks |
| src/utils/normalize_url_port.ts | Updated URL import path |
| src/anonymize_proxy.ts | Updated module imports for Buffer, http, net, and URL |
| src/utils/parse_authorization_header.ts | Updated Buffer import path |
| src/utils/redact_url.ts | Updated URL import path |
| src/custom_connect.ts | Updated module imports for http, net, and util |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (2)
eslint.config.mjs:1
- Ensure that switching from the base ESLint configuration to a TypeScript-specific configuration is intentional, as this change may affect linting for non-TypeScript files.
import apifyTypescriptConfig from '@apify/eslint-config/ts.js';
src/utils/count_target_bytes.ts:24
- [nitpick] Consider adding a clarifying comment to explain why an empty function is acceptable in this context, to better document the rationale behind suppressing this eslint rule.
// eslint-disable-next-line @typescript-eslint/no-empty-function
jancurn
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
@apify/eslint-configto a stable version