Skip to content

test: add ignoreUpstreamProxyCertificate tests#583

Merged
lewis-wow merged 4 commits into
masterfrom
test/add-ignore-upstream-proxy-certificate-test
Apr 4, 2025
Merged

test: add ignoreUpstreamProxyCertificate tests#583
lewis-wow merged 4 commits into
masterfrom
test/add-ignore-upstream-proxy-certificate-test

Conversation

@lewis-wow

@lewis-wow lewis-wow commented Mar 31, 2025

Copy link
Copy Markdown
Contributor

Add tests for ignoreUpstreamProxyCertificate proxy chain server prepareRequestFunction option.

@lewis-wow lewis-wow linked an issue Mar 31, 2025 that may be closed by this pull request
@github-actions github-actions Bot added this to the 111th sprint - Platform team milestone Mar 31, 2025
@github-actions github-actions Bot added t-core-services Issues with this label are in the ownership of the core services team. tested Temporary label used only programatically for some analytics. labels Mar 31, 2025
@lewis-wow lewis-wow force-pushed the test/add-ignore-upstream-proxy-certificate-test branch from 5fdea51 to 097248b Compare March 31, 2025 13:12
@lewis-wow lewis-wow requested a review from jirimoravcik March 31, 2025 13:57

@jirimoravcik jirimoravcik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please bump the version in package.json to 2.5.9? Thanks

@lewis-wow lewis-wow requested a review from jirimoravcik March 31, 2025 14:13
@lewis-wow lewis-wow marked this pull request as ready for review March 31, 2025 14:13

@jirimoravcik jirimoravcik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. Maybe it would be nice to add a comment describing how the test works?

@lewis-wow lewis-wow merged commit ec1ab92 into master Apr 4, 2025
@lewis-wow lewis-wow deleted the test/add-ignore-upstream-proxy-certificate-test branch April 4, 2025 07:53
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-core-services Issues with this label are in the ownership of the core services team. tested Temporary label used only programatically for some analytics. validated Issues that are resolved and their solutions fulfill the acceptance criteria.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a test for HTTPS proxy

3 participants