fix: can't run unit tests in docker#600
Merged
Merged
Conversation
6da3bab to
5fff11a
Compare
Member
|
SOCKS test is failing in CI |
Contributor
Author
|
@jirimoravcik should be fixed now. |
jirimoravcik
left a comment
Member
There was a problem hiding this comment.
Could we also add tests for newer Node.js versions in the CI? Now we have 14, 16, 18. Let's add 20, 22, 24 (soon LTS)
Contributor
Author
|
I've already checked node 22 and tests are failing there due to few breakable changes (e.g. node 22 don't allow us to response with status code |
Member
Yes, that's fine |
Contributor
Author
|
Here's issue about node version upgrade: #601 |
jirimoravcik
requested changes
Sep 29, 2025
jirimoravcik
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix Dockerfile and allows unit tests to run inside a container gracefully.
Also it specifies a node.js versionDiscussed later with Jirka that it's better not to have this file. All the tests must be fixed and should be compatible with newer versions of node all the time.18into.nvmrcfile to ensure compatibility.Resolves: #599