Skip to content

perf: do not publish tsbuildinfo file to npm#618

Merged
barjin merged 1 commit into
masterfrom
perf/dont-publish-tsbuildinfo
Nov 10, 2025
Merged

perf: do not publish tsbuildinfo file to npm#618
barjin merged 1 commit into
masterfrom
perf/dont-publish-tsbuildinfo

Conversation

@barjin

@barjin barjin commented Nov 10, 2025

Copy link
Copy Markdown
Member

Shrinks the package size by 13kB compressed or 35kB uncompressed space.

@barjin barjin requested review from B4nan and bliuchak November 10, 2025 07:42
@barjin barjin self-assigned this Nov 10, 2025
@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Nov 10, 2025
@github-actions github-actions Bot added this to the 127th sprint - Tooling team milestone Nov 10, 2025
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 10, 2025
B4nan
B4nan reviewed Nov 10, 2025
View reviewed changes

@B4nan B4nan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should be git ignored as well (then we dont need to modify the files option i guess?)

@barjin

barjin commented Nov 10, 2025

Copy link
Copy Markdown
Member Author

It's generated in dist/, so it's already .gitignored. Apparently, the files field has precedence over .npmignore, so adding it there didn't help either.

I suppose we could edit tsconfig to generate it in the repo root instead of dist (the current tsconfig is missing rootDir), but I took the path of least resistance (not sure about the other consequences of such change). wdyt?

B4nan
B4nan approved these changes Nov 10, 2025
View reviewed changes

@B4nan B4nan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wonder why this is not needed in crawlee or other repos, where we only gitignore the file.

@barjin

barjin commented Nov 10, 2025

Copy link
Copy Markdown
Member Author

why this is not needed in crawlee

It seems it is :)

image

By default, this file goes to outDir. If rootDir is set (see e.g. @crawlee/utils), then it goes in rootDir's and tsconfig's common parent (or something like that). More info in docs.

@barjin barjin merged commit f30cf89 into master Nov 10, 2025
6 checks passed
@barjin barjin deleted the perf/dont-publish-tsbuildinfo branch November 10, 2025 08:16
@B4nan

B4nan commented Nov 10, 2025

Copy link
Copy Markdown
Member

oh, i only checked the core package where its not present.

@barjin barjin mentioned this pull request Nov 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@B4nan B4nan B4nan approved these changes
@bliuchak bliuchak Awaiting requested review from bliuchak

Assignees

@barjin barjin

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Milestone

127th sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

2 participants

@barjin @B4nan