Skip to content

chore(ci): Clean up workflows, switch to publishing through OIDC#627

Merged
fnesveda merged 2 commits into
masterfrom
chore/clean-up-workflows
Dec 9, 2025
Merged

chore(ci): Clean up workflows, switch to publishing through OIDC#627
fnesveda merged 2 commits into
masterfrom
chore/clean-up-workflows

Conversation

@fnesveda

@fnesveda fnesveda commented Dec 8, 2025

Copy link
Copy Markdown
Member

NPM is deprecating publishing through classic tokens and recommending to publish through OIDC: https://github.blog/changelog/2025-09-29-strengthening-npm-security-important-changes-to-authentication-and-token-management/

In this PR, I've rewritten the publication workflows to use OIDC, and while doing that, I've cleaned them up a lot. I think the review would be easiest if you just viewed the files directly, not through the diff view. They're pretty short and readable now.

@fnesveda fnesveda self-assigned this Dec 8, 2025
@fnesveda fnesveda added the adhoc Ad-hoc unplanned task added during the sprint. label Dec 8, 2025
@github-actions github-actions Bot added the t-management Issues with this label belong to the CTO or engineering managers. label Dec 8, 2025
Comment thread .github/workflows/check.yaml Outdated
@fnesveda fnesveda requested a review from bliuchak December 9, 2025 09:34
@fnesveda fnesveda merged commit b4d2620 into master Dec 9, 2025
5 checks passed
@fnesveda fnesveda deleted the chore/clean-up-workflows branch December 9, 2025 15:19
jancurn pushed a commit that referenced this pull request Apr 22, 2026
PR #627 explicitly noted "Don't run tests on newer Node.js versions just
yet", and the suite still fails with ~94 assertions on Node.js 24 /
ubuntu-latest (IPv6 behaviour, byte-count expectations, HTTP parsing
differences). Until the tests are updated for modern Node, run the e2e
job on the same combination master has been passing on so CI is green.
Unit tests keep running across Node.js 20/22/24 on ubuntu-latest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-management Issues with this label belong to the CTO or engineering managers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants