Skip to content

(fix): param default#11734

Merged
abnegate merged 1 commit into
1.9.xfrom
fix-defaults
Apr 1, 2026
Merged

(fix): param default#11734
abnegate merged 1 commit into
1.9.xfrom
fix-defaults

Conversation

@abnegate
Copy link
Copy Markdown
Member

@abnegate abnegate commented Apr 1, 2026

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@abnegate abnegate merged commit 8c6d4d8 into 1.9.x Apr 1, 2026
9 of 10 checks passed
@abnegate abnegate deleted the fix-defaults branch April 1, 2026 02:50
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 1, 2026

Greptile Summary

This PR fixes an inconsistency between the Utopia framework param declaration and the PHP method signature default value for the $migrate parameter in Upgrade::action().

  • The __construct method already declared the migrate param with a default of false (line 33: ->param('migrate', false, ...)), but the action() method signature had bool $migrate = true — an opposing default.
  • The fix changes the method-signature default from true to false, making both consistent.
  • In normal framework usage the ->param() default governs what value is injected, so this was likely only observable when action() was called directly in PHP without the argument. The fix is still correct and prevents any surprise if the method is ever called outside the framework context.

Confidence Score: 5/5

Safe to merge — single-line fix that aligns two previously inconsistent default values.

The change is minimal, correct, and addresses a clear inconsistency between the framework param declaration (default false) and the PHP method signature (default true). No logic is altered beyond reconciling these two defaults. No P0/P1 issues found.

No files require special attention.

Important Files Changed

Filename Overview
src/Appwrite/Platform/Tasks/Upgrade.php Changed the default value of $migrate in action() from true to false, making it consistent with the ->param() declaration in the constructor which already defaulted to false.

Reviews (1): Last reviewed commit: "(fix): param default" | Re-trigger Greptile

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026

🔄 PHP-Retry Summary

Flaky tests detected across commits:

Commit 2ebc6f7 - 4 flaky tests
Test Retries Total Time Details
LegacyConsoleClientTest::testListDocumentsWithCache 1 1.42s Logs
LegacyCustomClientTest::testAttributeResponseModels 1 241.52s Logs
LegacyCustomServerTest::testEnforceCollectionPermissions 1 240.39s Logs
UsageTest::testVectorsDBStats 1 10.05s Logs

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026

✨ Benchmark results

  • Requests per second: 1,578
  • Requests with 200 status code: 284,150
  • P99 latency: 0.113859276

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,578 1,094
200 284,150 196,972
P99 0.113859276 0.204921958

@blacksmith-sh
Copy link
Copy Markdown

blacksmith-sh Bot commented Apr 1, 2026

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
› Tests\E2E\Services\TablesDB\Transactions\TablesDBTransactionsCustomServerTest/
testConcurrentTransactionConflicts
View Logs

Fix in Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant