chore: Remove unused deps#18035
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bfa5d98519
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "devDependencies": { | ||
| "@babel/core": "workspace:^", | ||
| "@babel/helper-transform-fixture-test-runner": "workspace:^" | ||
| "@babel/core": "workspace:^" | ||
| }, |
There was a problem hiding this comment.
Restore fixture runner dev dependency
When the babel-build-external-helpers batch tests run, test/batch-test-runner/*.js imports test/helpers/runner.js, and that helper imports @babel/helper-transform-fixture-test-runner directly. Removing it from this package's devDependencies leaves the workspace relying on an undeclared/hoisted package, so an isolated workspace install or dependency validation will fail to load those tests.
Useful? React with 👍 / 👎.
| "@babel/helper-plugin-test-runner": "workspace:^", | ||
| "@babel/helper-transform-fixture-test-runner": "workspace:^", | ||
| "@babel/parser": "workspace:^", | ||
| "regenerator-runtime": "^0.14.0", | ||
| "terser": "catalog:dev" |
There was a problem hiding this comment.
Keep regenerator-runtime with helpers
packages/babel-helpers/scripts/generate-regenerator-runtime.js resolves regenerator-runtime relative to @babel/helpers (createRequire(import.meta.url).resolve("regenerator-runtime")), and the comment in that script says to update the regenerator-runtime dependency of this package before regenerating. Moving the dependency to @babel/plugin-transform-regenerator leaves the helper-generation script unable to resolve its input in contexts that enforce package boundaries.
Useful? React with 👍 / 👎.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61691 |
|
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c80bc745bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Fixes #1, Fixes #2I've resolved some of the Knip reports, but the rest are false positives, and I haven't figured out a good solution yet.