JavaScript-Group-Capstone(CountDown Movies)#36
Conversation
Display Movies
Added css and popup function
Using API's to get like functions
Add comment and comment count
Add comment and comment count
Add comment and comment count
Github deploy pages
Testing for movie counts
Added test file and Completed test
Presentation video
julie-ify
left a comment
There was a problem hiding this comment.
Hi @ramrod433 and @braincee,
Highlights!
- No linter errors ✔️
- Descriptive pull request ✔️
- Test passed✔️
- Good code organization and working app ✔️
- Descriptive README ✔️
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Status: Approved ✔️
Cheers and Happy coding!👏👏👏
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
Thank you very much @julie-ify @ramrod433
|
In this pull request, the following requirements were implemented:
My partner and I :
Set up your Kanban board
Found external API - group task
Chose assets - group task
Set up the project with Webpack and Jest- group task
Added header - group task
Added footer - group task
Displayed list of items on the Homepage
Displayed Comments pop up with selected item's details
Displayed number of likes for each item on the Homepage
Displayed comments for a given item on the Comments pop-up
Created feature: add new like
Created feature: add new comment
Added all items counter on the Homepage
Added comments counter
Added tests for items counter and comments counter