This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Add Express example#577
Merged
mayurkale22 merged 2 commits intoJun 10, 2019
Merged
Conversation
Member
Author
|
/cc @odeke-em |
odeke-em
approved these changes
Jun 7, 2019
odeke-em
left a comment
Member
There was a problem hiding this comment.
LGTM and thank you @mayurkale22! Just one thing we need to ensure that we let the users know about this change. They need to first initialize the tracer BEFORE creating the express app, otherwise users will spend hours debugging just like I did :)
odeke-em
reviewed
Jun 7, 2019
| serviceName: 'opencensus-express' | ||
| }); | ||
|
|
||
| // Starts tracing and set sampling rate, exporter and propagation |
Member
There was a problem hiding this comment.
Perhaps let's add:
// NOTE: Please ensure that you start the tracer BEFORE initializing your express app
odeke-em
reviewed
Jun 7, 2019
| propagation: new propagation.B3Format(), | ||
| logLevel: 1 // show errors, if any | ||
| }); | ||
|
|
Member
There was a problem hiding this comment.
Perhaps let's add:
// NOTE: Please ensure that you initialize your express app AFTER initializing the OpenCensus Tracer.
Member
Author
Sure, I will do the needful. Thanks for suggestion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.