Fix propagation breaking for https.get#657
Conversation
shamelful copy from the http plugin code, to fix the `https.get` same as `http.get`.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
==========================================
+ Coverage 95.43% 95.59% +0.16%
==========================================
Files 148 10 -138
Lines 10730 659 -10071
Branches 799 52 -747
==========================================
- Hits 10240 630 -9610
+ Misses 490 29 -461
Continue to review full report at Codecov.
|
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
| 'get', | ||
| this.getPatchHttpsOutgoingRequest() | ||
| ); | ||
| shimmer.wrap(this.moduleExports, 'get', () => { |
There was a problem hiding this comment.
@mayurkale22 I could not figure out how to change the http module to put this code into a method there, and then I could have just referenced it from this https module...
But everything references a specific version(test and code) so I did not spend more time in trying to figure out how to do this.
Hence the reason I ended up coping the same code from the http module and just dumping it here.
draffensperger
left a comment
There was a problem hiding this comment.
Thanks @loneparadox for this contribution! I'm OK with the duplication personally particularly given that we are transitioning efforts to OpenTelemetry JS.
@mayurkale22 WDYT?
I agree with @draffensperger. I will fine with merging like this. |
|
I'd like to encourage you to consider looking the https://github.com/open-telemetry/opentelemetry-js repo. This would be the next major release of OpenCensus + OpenTracing merger. We are getting ready for Alpha release, within 1-2 days. |
shameful copy from the http plugin code, to fix the
https.getsame ashttp.get.#653
Copied from https://github.com/census-instrumentation/opencensus-node/pull/324/files