fix(resources): GKE pod name label#728
Conversation
|
/cc @fiws please review |
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
=========================================
+ Coverage 95.36% 95.4% +0.04%
=========================================
Files 147 148 +1
Lines 10684 10694 +10
Branches 798 801 +3
=========================================
+ Hits 10189 10203 +14
+ Misses 495 491 -4
Continue to review full report at Codecov.
|
|
@mayurkale22 Thanks for addressing my issue. This looks like it solves my problem. Edit: i thought the hostname would be the only source for the pod now. i did not correctly read the code ... everything is fine |
|
Hello, I'm running into this issue and @mayurkale22 's code does indeed fix the problem. Any hint about when it will be merged ? Thanks a lot! |
86b3752 to
ba12b53
Compare
|
@draffensperger Please review when you get a chance. |
Sorry for the delay, waiting for PR to get approved. I will include this in |
Published in |
|
Working as expected by now, thanks ! |
Ok great, thanks for the confirmation. |
Resolves #727
These changes have all been tested locally against a real GKE and Stackdriver instance and been confirmed to be working.