Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

chore: use github actions for CI runs#905

Merged
aabmass merged 1 commit into
census-instrumentation:masterfrom
aabmass:gha-ci
Jul 19, 2021
Merged

chore: use github actions for CI runs#905
aabmass merged 1 commit into
census-instrumentation:masterfrom
aabmass:gha-ci

Conversation

@aabmass

@aabmass aabmass commented Jul 15, 2021

Copy link
Copy Markdown
Member

Part 2 after #906
Fixes #891

  • Drops CI for Node 11 (which was not a LTS release) adds 14 and 16 which are active. Keeping Node 10 CI for now.
  • Should otherwise be the same as existing CircleCI jobs
  • Not migrating the CircleCI publish_npm job yet. This just migrates CI jobs.

@google-cla google-cla Bot added the cla: yes label Jul 15, 2021
@aabmass aabmass force-pushed the gha-ci branch 12 times, most recently from dd2ef5e to fe85402 Compare July 16, 2021 12:06
@aabmass aabmass force-pushed the gha-ci branch 4 times, most recently from 82bac7f to 693c18a Compare July 16, 2021 13:13
Comment thread .github/workflows/ci.yaml
run: npm run test -- ${{ matrix.npm_script_extra_args }}
- name: Submit coverage data to codecov.
run: npm run codecov -- ${{ matrix.npm_script_extra_args }}
if: ${{ success() && matrix.node == '12' }}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this would run on newest node, but workaround for codecov/codecov-node#284

@aabmass aabmass force-pushed the gha-ci branch 7 times, most recently from e47bd9e to e176c03 Compare July 16, 2021 17:31
@aabmass aabmass marked this pull request as ready for review July 19, 2021 18:12
@aabmass aabmass requested a review from draffensperger as a code owner July 19, 2021 18:12
@aabmass aabmass merged commit e1c20ed into census-instrumentation:master Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add node14 to CI

2 participants