Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

chore: upgrade gRPC, ts to newest compatible version#907

Merged
aabmass merged 1 commit into
census-instrumentation:masterfrom
aabmass:up-grpc
Jul 19, 2021
Merged

chore: upgrade gRPC, ts to newest compatible version#907
aabmass merged 1 commit into
census-instrumentation:masterfrom
aabmass:up-grpc

Conversation

@aabmass

@aabmass aabmass commented Jul 16, 2021

Copy link
Copy Markdown
Member
  • Upgrade "grpc": "^1.24.10"
    • the old release was 3 years old and didn't have precompiled binaries anymore
  • Upgrade "typescript": "^3.9.10"
    • newer grpc versions don't seem to work with typescript 2.x. This is true of many other deps.
    • I marked this as BREAKING CHANGE in the changelog. However, the generated type stubs should be unchanged and continue to work with 2.x until we start using new features e.g. unknown type
  • Upgrade "@types/node": "^10.17.60 – this version works with Typescript 3.x

For newly introduced errors from the newer typescript and @types/node packages, added @ts-expect-error FIXMEs in the code base. Many of these are probably easy to fix, so I will file an issue to do that after this is merged.

@aabmass aabmass merged commit 9bd4f11 into census-instrumentation:master Jul 19, 2021
@aabmass aabmass deleted the up-grpc branch July 19, 2021 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants