Parse SQL queries correctly#17
Merged
Merged
Conversation
The grammars are taken from the antlr-grammars project but modified slightly (file and grammar names are renamed from x to xCore)
Owner
|
Hi @diotteo This looks great! Thanks for the contribution! |
Owner
|
@diotteo I'll prepare a release with your contribution soon |
Owner
|
These changes are now included in the latest release. Thanks again for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last version of the software parses the input in the Query window by splitting the string on semicolons and then decides whether to display its output based on whether the resulting substring starts with "select".
This creates issues with comments. For example, this is the output of the software at the moment:
In this branch, I integrate the Antlr4 parser so that comments are parsed away correctly. This permits using comments:
This functionality is most useful when doing quick-and-dirty updates. Example:
