fix(time): restore stream subpath entrypoints#1003
Open
shriram-svg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #672.
Summary
@cycle/time/rxjsand@cycle/time/mostroot entrypoint shims during the package build.srcfiles.Verification
npx --yes pnpm@7.33.7 install --frozen-lockfilenpx --yes pnpm@7.33.7 --filter @cycle/run run buildnpx --yes pnpm@7.33.7 --filter @cycle/dom run buildnpx --yes pnpm@7.33.7 --filter @cycle/time run buildnode -e "const rx = require('./time/rxjs'); const most = require('./time/most'); if (typeof rx.mockTimeSource !== 'function') throw new Error('missing rxjs mockTimeSource'); if (typeof rx.timeDriver !== 'function') throw new Error('missing rxjs timeDriver'); if (typeof most.mockTimeSource !== 'function') throw new Error('missing most mockTimeSource'); if (typeof most.timeDriver !== 'function') throw new Error('missing most timeDriver'); console.log('package-path subpath shims ok');"npm pack --dry-run --json | node -e "...assert required files are present..."package/rxjsandpackage/mostnpx --yes pnpm@7.33.7 --filter @cycle/time run lint./node_modules/.bin/prettier --list-different time/.scripts/make-entrypoints.js time/package.jsongit diff --checknpx --yes pnpm@7.33.7 --filter @cycle/time run test