Skip to content

fix(devtool): allow delayed app graph detection#1004

Open
shriram-svg wants to merge 1 commit into
cyclejs:masterfrom
shriram-svg:fix-issue-436-devtool-recognition
Open

fix(devtool): allow delayed app graph detection#1004
shriram-svg wants to merge 1 commit into
cyclejs:masterfrom
shriram-svg:fix-issue-436-devtool-recognition

Conversation

@shriram-svg
Copy link
Copy Markdown

Fixes #436.

Summary

  • Keep the DevTool's initial invalid state from permanently setting the graph serializer as started.
  • Allow the later @cycle/run hook to provide real app sinks after the inspected app finishes booting.
  • Avoid duplicate invalid-state emissions if no compatible xstream sinks are found.

Verification

  • npx --yes pnpm@7.33.7 install --frozen-lockfile --store-dir /tmp/pnpm-cyclejs-store-436
  • yarn install --frozen-lockfile in devtool/
  • git diff --check

Existing verification blockers

  • npm run lint in devtool/ fails on existing lint violations across graphSerializer.ts, launcher.ts, panel/index.ts, and panel/model.ts (object access via string literals is disallowed, plus one shadowed name).
  • npm run lib in devtool/ fails on existing TypeScript errors in old dependency declarations and existing source files, including @cycle/dom, @cycle/run, xstream, contentScript.ts, graphSerializer.ts, launcher.ts, panel/index.ts, and utils/timeSpread.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DevTool doesn't recognize app as being Cyclejs

2 participants