fix(http): support browser File attachments#1021
Open
cerredz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #294.
The HTTP driver previously assumed every
attachentry used the Node-style{ name, path, filename }shape, which breaks for browserFileobjects from<input type=file>because those objects have nopathorfilenameproperty.This keeps the existing Node path behavior and adds browser-only handling for:
attach: [file]attach: [{ name: 'file', file, filename: 'hello.txt' }]Node behavior is guarded so Node 22's global
Filedoes not accidentally take the browser path when using Node superagent.Verification:
npm run lint --prefix httpnpx tsc --project http\\tsconfig.json --module commonjs --outDir http\\lib\\cjsnpx tsc --project http\\tsconfig.json --module es6 --outDir http\\lib\\es6npm run test-node --prefix http(26 passing, 2 browser-only tests pending in Node)karma start http/karma.conf.js --browsers ChromeHeadless --single-runwith the HTTP support server running (28/28 passing)