dbeaver/pro#9394: fix renaming in TE#41176
Open
SolovevAnton wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses connection renaming behavior in Team Edition by allowing datasource updates to skip forcing secrets persistence, and wires the rename operation to use the registry update path accordingly.
Changes:
- Added a
updateDataSource(dataSource, forcePersistSecrets)overload toDBPDataSourceRegistry(as a default method for compatibility). - Implemented the new overload in
DataSourceRegistryand threadedforcePersistSecretsinto secret persistence. - Updated datasource rename flow to use
registry.updateDataSource(..., false)instead ofpersistConfiguration().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| plugins/org.jkiss.dbeaver.registry/src/org/jkiss/dbeaver/registry/DataSourceRegistry.java | Adds/implements an overload to control whether secret persistence is forced during datasource updates. |
| plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/model/navigator/DBNDataSource.java | Updates rename implementation to persist via registry update without forcing secrets persistence. |
| plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/model/app/DBPDataSourceRegistry.java | Introduces a backward-compatible default overload for updating datasources with a secrets persistence flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
E1izabeth
previously approved these changes
May 27, 2026
IvanGorshechnikov
requested changes
Jun 2, 2026
E1izabeth
approved these changes
Jun 3, 2026
IvanGorshechnikov
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: dbeaver/pro#9394