#41253 Build CubridDataSource for generic driver connections#41254
Open
Srltas wants to merge 1 commit into
Open
#41253 Build CubridDataSource for generic driver connections#41254Srltas wants to merge 1 commit into
Srltas wants to merge 1 commit into
Conversation
Override createDataSourceImpl() in CubridMetaModel so generic driver connections build a CubridDataSource instead of a GenericDataSource, fixing the ClassCastException when listing tables.
E1izabeth
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Connecting to CUBRID with the generic driver (instead of the bundled CUBRID driver) throws a ClassCastException as soon as you expand the table list:
CubridMetaModel is picked by driver class match (
cubrid.jdbc.driver.CUBRIDDriver), but on the generic provider path the data source is created as a plain GenericDataSource. CubridMetaModel then casts it to CubridDataSource unconditionally, so it fails right when metadata loading starts. The underlying reason is that CubridMetaModel never overrodecreateDataSourceImpl(), unlike Altibase and most other generic extensions.Changes
createDataSourceImpl()in CubridMetaModel so the generic path builds a CubridDataSource as well. This makes the cast safe on both the dedicated and generic provider paths.openDataSource()override in CubridDataSourceProvider, since the parent provider already routes throughcreateDataSourceImpl().Fixes #41253