fix: log eigenvalue monitor values#8049
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
e1d9360 to
9b2996a
Compare
Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
9b2996a to
483fbba
Compare
Author
|
Rebased this branch onto the latest upstream Validated locally:
I also tried the focused pytest target locally:
That collection failed in this Windows checkout before running the test because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
self.ev_valuesreference in eigenvalue monitor loggingdict_valuesview returned byself.block_eigenvalue.values()Fixes #7983.
To verify
python -m py_compile deepspeed\runtime\engine.py tests\unit\runtime\test_engine_eigenvalue.pygit diff --checkI also tried
python -m pytest tests\unit\runtime\test_engine_eigenvalue.py -qon this Windows checkout. Collection failed before the test body because the local package import resolvesdeepspeed.acceleratordifferently in this clone/environment. The touched code and the helper itself both compile, and the helper smoke test exercises the exact event construction without importing the full package.