Better Linux checking for Fasthash binaries#1910
Open
tomasthedev wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue:
Currently
os.nameis used to detect Linux to download fasthash binary by comparing theos.nametoposix.However the
os.namewill result toposixon all unix/unix like operating systems like on FreeBSD or OpenBSDThe same goes for the donate binaries
Fix:
Using os.uname().system instead or alongside would be a better practice. To compare it to
Linux.This is going to add better debugging and better support for unix-like/unix operating systems in future