fixing directory name, etc to keep backward compatibility #3
Closed
manos wants to merge 1 commit into
Closed
Conversation
…ich followed the docs and used 'from DynectDNS import DynectRest'... and added pip install instructions to the README.
Contributor
|
Thanks - I appreciate the feedback. I made a couple changes before realizing that this pull request was submitted. Mind taking a look at the latest version and see if it takes care of your concerns? If not, let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amazing timing; I was working on making it installable too :)
One thing to fix with the committed version: existing scripts that followed the docs and used 'from DynectDNS import DynectRest'... will be broken if the user pip installs. I renamed directory and updated setup.py to fix this. Also, added pip install instructions to the README.