fix(sse): preserve empty data lines when formatting SSE#15618
Closed
MatiasFormoso wants to merge 1 commit into
Closed
fix(sse): preserve empty data lines when formatting SSE#15618MatiasFormoso wants to merge 1 commit into
MatiasFormoso wants to merge 1 commit into
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
Member
|
@MatiasFormoso, thanks! I'll close this to avoid having duplicates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
format_sse_event(data_str='') currently emits no data: line, which can drop an intended empty event payload. This change keeps empty and trailing lines explicit in the SSE output.
Tests
Made with Cursor