Fix/issue 4685#6758
Open
BALOGUN-DAVID wants to merge 1 commit into
Open
Conversation
Eomm
requested changes
Jun 6, 2026
67f8e13 to
6f30748
Compare
6f30748 to
0129721
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4685
This PR restores the ability for developers to provide an explicit return type via a generic type argument on
RouteHandlerMethodand related routing shorthand methods. In Fastify v4, the generic return type was removed in favor of strict type inference usingResolveFastifyReplyReturnType, which unfortunately broke community plugins (likefastify-funky) and custom hooks that needed to extend or override the return type signature of route handlers.To fix this while maintaining v4's strict default type inference, this PR introduces a new
ResolveReplygeneric type parameter. It is placed at the end of the generics list and defaults directly toResolveFastifyReplyReturnType<TypeProvider, SchemaCompiler, RouteGeneric>. This ensures total backward compatibility for users who don't supply the parameter, while providing the requested escape hatch for those who do.Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct