Skip to content

Policies: show tooltip when multiple automations are configured#46934

Open
nulmete wants to merge 1 commit into
mainfrom
nulmete/show-tooltip-automations-policies-page
Open

Policies: show tooltip when multiple automations are configured#46934
nulmete wants to merge 1 commit into
mainfrom
nulmete/show-tooltip-automations-policies-page

Conversation

@nulmete
Copy link
Copy Markdown
Member

@nulmete nulmete commented Jun 5, 2026 •
edited by coderabbitai Bot
Loading

Related issue: Resolves:

Screenshot 2026-06-05 at 3 27 19 PM

Testing

  • QA'd all new/changed functionality manually
Screenshot 2026-06-05 at 3 25 42 PM

Summary by CodeRabbit

  • UI Improvements
    • Enhanced tooltip display with arrow indicators for improved visual clarity when viewing automation details.

Copilot AI review requested due to automatic review settings June 5, 2026 18:29
@nulmete nulmete requested a review from a team as a code owner June 5, 2026 18:29
claude[bot]
claude Bot reviewed Jun 5, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copilot AI reviewed Jun 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Policies table “Automations” cell tooltip presentation so that when a policy has multiple automations, the tooltip includes an arrow indicator (via TooltipWrapper’s showArrow prop). This fits into the frontend’s existing tooltip system (components/TooltipWrapper) and aligns with how other UI tooltips in the repo opt into arrow styling.

Changes:

  • Enable showArrow on the tooltip that lists automation names when automations.length > 1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b7c2337c-5cce-4f9f-91eb-d6d1db09ee36

📥 Commits

Reviewing files that changed from the base of the PR and between 3a21e31 and 37fa709.

📒 Files selected for processing (1)
  • frontend/pages/policies/ManagePoliciesPage/components/PoliciesTable/PoliciesTableConfig.tsx

Walkthrough

This PR adds the showArrow prop to the TooltipWrapper component in AutomationsCell within the PoliciesTableConfig file. The change enables the tooltip arrow display when showing information about multiple automations. No logic, data handling, or exported APIs are altered.

Possibly related PRs

  • fleetdm/fleet#46910: Also modifies the AutomationsCell component in the same file, refactoring the UI/readonly behavior of the automations column tooltip.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete and missing critical information required by the template, including issue reference, changes files, testing details, and other mandatory checklist items. Complete the PR description by specifying the related issue number, ensuring all applicable checklist items are addressed, and providing clear context for the change beyond just screenshots.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: enabling a tooltip arrow display for the automations configuration in the policies page.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nulmete/show-tooltip-automations-policies-page

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.02%. Comparing base (4311a44) to head (37fa709).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #46934    +/-   ##
========================================
  Coverage   67.02%   67.02%            
========================================
  Files        2861     2861            
  Lines      224836   224836            
  Branches    11738    11596   -142     
========================================
  Hits       150703   150703            
  Misses      60480    60480            
  Partials    13653    13653
Flag Coverage Δ
frontend 56.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@claude claude[bot] claude[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@RachelElysia RachelElysia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nulmete @RachelElysia