fix(curriculum): audit editable regions for reusable mega navbar#67782
Open
rustom-yadav wants to merge 4 commits into
Open
fix(curriculum): audit editable regions for reusable mega navbar#67782rustom-yadav wants to merge 4 commits into
rustom-yadav wants to merge 4 commits into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
76 tasks
Contributor
majestic-owl448
left a comment
There was a problem hiding this comment.
please also update step 5, and make sure to include indentation inside the editable region so that the learner does not need to think abou that
Contributor
Author
yes i did this , |
46dd978 to
479809a
Compare
479809a to
a56153f
Compare
Contributor
majestic-owl448
left a comment
There was a problem hiding this comment.
While the editable-region audit itself looks good, a couple of pre-existing continuity issues are worth fixing while this block is open:
- The
Dashboardanchor is written with single quotes (<a href='/browse?url=https%3A%2F%2Fgithub.com%2FfreeCodeCamp%2FfreeCodeCamp%2Fpull%2F67782%23'>Dashboard</a>) in steps 6, 7, 8, 9, 10, and 11 (including step 11's solution block), while every other anchor in the workshop uses double quotes. Please normalize it to<a href="/browse?url=https%3A%2F%2Fgithub.com%2FfreeCodeCamp%2FfreeCodeCamp%2Fpull%2F67782%23">Dashboard</a>everywhere for consistency with the rest of the block and the JS style guide. I left an inline suggestion on step 6. - Step 9 (
6745dce846995b2a466594be.md, line 150) uses<nav class="navbar">, while every other step and the final solution use<nav className="navbar">. Please change it toclassNameto keep the steps consistent and avoid the React invalid-attribute warning.
| @@ -164,11 +164,13 @@ export const Navbar = () => { | |||
| <li className="nav-item"> | |||
| <a href='#'>Dashboard</a> | |||
Contributor
There was a problem hiding this comment.
Suggested change
| <a href='#'>Dashboard</a> | |
| <a href="#">Dashboard</a> |
For consistency with every other anchor in this workshop (which use double quotes) and the JS style guide, please use double quotes here. Please fix also in steps 7, 8, 9, 10, and 11 (including the solution block in step 11), which use single quotes for this anchor too.
Contributor
Author
There was a problem hiding this comment.
yeah i got this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.This PR audits and updates the
--fcc-editable-region--markers for theworkshop-reusable-mega-navbarworkshop (part of the v9 Front-End Development Libraries superblock).As per the curriculum audit guidelines, the markers have been adjusted to strictly wrap only the specific lines/blocks that a camper needs to modify for each step, removing any unnecessary context or unchanged boilerplate lines.
Related Issues
References #67721 (Part of Naomi's Contribution Sprints — v9 workshops audit).