chore(android-sqlite): Add SQLite samples to sentry-samples-android#5504
chore(android-sqlite): Add SQLite samples to sentry-samples-android#55040xadam-brown wants to merge 4 commits into
Conversation
Adds our SQLite integrations to sentry-android-samples (`SentrySQLiteDriver` and `SentrySupportOpenSQLiteHelper`). The entry point is `SQLiteActivity`. Example SQL statements are identical across integrations so we can observe similarities / differences in how they handle spans. Users can exercise the integrations directly or via Room or SQLDelight.
📲 Install BuildsAndroid
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f8d2380 | 309.09 ms | 365.52 ms | 56.43 ms |
| 2a55b58 | 365.41 ms | 434.64 ms | 69.23 ms |
| 4993a1b | 303.45 ms | 392.65 ms | 89.20 ms |
| 9ed1dfc | 310.92 ms | 361.74 ms | 50.82 ms |
| 703e7ae | 350.72 ms | 415.76 ms | 65.03 ms |
| 8c92b97 | 310.02 ms | 361.44 ms | 51.42 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f8d2380 | 0 B | 0 B | 0 B |
| 2a55b58 | 0 B | 0 B | 0 B |
| 4993a1b | 0 B | 0 B | 0 B |
| 9ed1dfc | 0 B | 0 B | 0 B |
| 703e7ae | 0 B | 0 B | 0 B |
| 8c92b97 | 0 B | 0 B | 0 B |
| room2 = "2.8.4" | ||
| room3 = "3.0.0-alpha06" | ||
| sqlite = "2.6.2" | ||
| sqliteAlpha = "2.7.0-alpha06" # Required by Room3 3.0.0-alpha* |
There was a problem hiding this comment.
I've included deps that are only relevant to the sample app b/c that matched prior art. Chime in if you want me to break with that practice and move the new sample app deps to its build.gradle file.
| @@ -0,0 +1,106 @@ | |||
| package io.sentry.samples.android.sqlite | |||
There was a problem hiding this comment.
From here on I've flagged what few items I think are of interest. Your time is probably better spent spinning up the sample app from a local branch and seeing whether you have any feedback.
| applicationId = "io.sentry.samples.android" | ||
| minSdk = libs.versions.minSdk.get().toInt() | ||
| // androidx.sqlite 2.6+ require minSdk 23; the Sentry SDK still supports 21. | ||
| minSdk = 23 |
There was a problem hiding this comment.
Note that Room 3 requires us to bump the Android sample app minSDK to 23 and JVM target to 11.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8b3c175. Configure here.
| kotlin = "2.2.0" | ||
| kotlinSpring7 = "2.2.0" | ||
| kotlin-compatible-version = "1.9" | ||
| ksp = "2.2.0-2.0.2" |
There was a problem hiding this comment.
would ksp 2.3.X be compatible? that would untie it from the kotlin version compatibility issue.
📜 Description
Adds our SQLite integrations to sentry-android-samples (
SentrySQLiteDriverandSentrySupportOpenSQLiteHelper).The entry point is
SQLiteActivity. Example SQL statements are identical across integrations so we can observe similarities / differences in how they handle spans. Users can exercise the integrations directly or via Room or SQLDelight.💡 Motivation and Context
Follow-on to #5466 so we can vet
SentrySQLiteDriverin the wild. Backfills to coverSentrySupportOpenSQLiteHelper.How do I use it?
Then click "Tracing" > "Open SQLiteActivity"
Screenshots
💚 How did you test it?
Manually.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps