feat(android): Add binder (IPC) tracing and logging instrumentation#5515
Draft
markushi wants to merge 2 commits into
Draft
feat(android): Add binder (IPC) tracing and logging instrumentation#5515markushi wants to merge 2 commits into
markushi wants to merge 2 commits into
Conversation
Contributor
|
📲 Install BuildsAndroid
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds an internal
SentryBinderAdapterthat hooks into Android binder (IPC) calls, together with two new opt-inSentryAndroidOptions:enableBinderTracing(io.sentry.traces.binder.enable) — creates child spans on the active transaction for binder calls, annotated with thread id/name.enableBinderLogging(io.sentry.logs.binder.enable) — emits a Sentry log entry for each binder call.Both options default to
falseand can also be configured viaAndroidManifest.xmlmetadata. The adapter is wired up duringSentryAndroid.initand is designed to never crash the host app (all instrumentation is wrapped in defensive try/catch).💡 Motivation and Context
Binder (IPC) calls can be a significant and hard-to-diagnose source of latency on Android. Surfacing them as spans and/or logs gives developers visibility into IPC activity happening on their threads.
💚 How did you test it?
Added unit tests for
SentryBinderAdapter, the newSentryAndroidOptionsgetters/setters, andManifestMetadataReaderparsing of the new manifest attributes.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps