fix(license): Attribute vendored AndroidX Compose UI code in Session Replay#5516
Open
romtsn wants to merge 1 commit into
Open
fix(license): Attribute vendored AndroidX Compose UI code in Session Replay#5516romtsn wants to merge 1 commit into
romtsn wants to merge 1 commit into
Conversation
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2387c2c | 317.04 ms | 354.60 ms | 37.56 ms |
| 91bb874 | 310.68 ms | 359.24 ms | 48.56 ms |
| cf708bd | 408.35 ms | 458.98 ms | 50.63 ms |
| 2195398 | 321.31 ms | 391.66 ms | 70.35 ms |
| e2dce0b | 315.85 ms | 369.20 ms | 53.35 ms |
| 991b33b | 326.08 ms | 397.82 ms | 71.73 ms |
| 4c04bb8 | 350.71 ms | 413.63 ms | 62.92 ms |
| 3699cd5 | 423.60 ms | 495.52 ms | 71.92 ms |
| 70118e9 | 380.00 ms | 475.72 ms | 95.72 ms |
| 694d587 | 312.37 ms | 402.77 ms | 90.41 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2387c2c | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 91bb874 | 1.58 MiB | 2.13 MiB | 559.07 KiB |
| cf708bd | 1.58 MiB | 2.11 MiB | 539.71 KiB |
| 2195398 | 0 B | 0 B | 0 B |
| e2dce0b | 0 B | 0 B | 0 B |
| 991b33b | 0 B | 0 B | 0 B |
| 4c04bb8 | 0 B | 0 B | 0 B |
| 3699cd5 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| 70118e9 | 1.58 MiB | 2.29 MiB | 719.84 KiB |
| 694d587 | 1.58 MiB | 2.19 MiB | 620.06 KiB |
sentry-android-replay's Nodes.kt vendors code from AndroidX Compose UI (Apache 2.0, The Android Open Source Project) without attribution: - boundsInWindow is a faster copy of LayoutCoordinates.boundsInWindow - fastMinOf/fastMaxOf/fastCoerceIn/fastCoerceAtLeast/fastCoerceAtMost are copied from androidx.compose.ui.util.MathHelpers Add the required source-file attribution header and a THIRD_PARTY_NOTICES.md entry covering both source files. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
5eeba1f to
1e8fd79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
sentry-android-replay'sNodes.ktvendors code from AndroidX Compose UI (Apache-2.0, The Android Open Source Project) without attribution:boundsInWindowis an adapted ("faster copy") ofLayoutCoordinates.boundsInWindow.fastMinOf/fastMaxOf/fastCoerceIn/fastCoerceAtLeast/fastCoerceAtMostare copied fromandroidx.compose.ui.util.MathHelpers.This PR adds:
Nodes.kt(vendoring origin, both source URLs, copyright, Apache-2.0 license);THIRD_PARTY_NOTICES.mdentry (both Source URLs, License, Copyright, Scope, full Apache-2.0 text).This is pre-existing vendored code on
main; thesentry-warden[bot]check-code-attributionfinding surfaced it on #5507 (which modifiesboundsInWindow). Splitting the attribution fix out so it can land independently.💡 Motivation and Context
Addresses the
check-code-attributionfinding (LL3-2QU) reported by Warden. Apache-2.0 is permissive/compatible per https://open.sentry.io/licensing/ — this PR only adds the legally-required attribution, no behavior change.💚 How did you test it?
Not applicable — attribution/licensing only (header comment +
THIRD_PARTY_NOTICES.md). Verified the module still compiles andspotlessApply apiDumpproduced no API changes.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog