fix: warn on deprecated Gemini model alias#6011
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
Collaborator
|
Response from ADK Triaging Agent Hello @he-yufeng, thank you for creating this PR! We noticed a couple of items from our contribution guidelines that could be added to help the review process:
This additional context will help the reviewers understand and verify the fix more efficiently. Thank you! |
Collaborator
🔍 ADK Pull Request Analysis: PR #6011Title: fix: warn on deprecated Gemini model alias Executive Summary
Detailed Findings & Analysis1. Objectives & Impact ("What does it do?")
2. Justification & Value ("Is it a valid and useful change?")
3. Principle & Style Alignment Checklist ("Does it follow rules?")
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LLMRegistry.new_llm()sees the deprecatedgemini-flash-latestaliasgemini:-prefixed alias usageFixes #6010.
To verify
PYTHONPATH=src python -m pytest tests\unittests\models\test_models.py -qpython -m pyink --check src\google\adk\models\registry.py tests\unittests\models\test_models.pygit diff --check