This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: handle Starlette routes in FastAPI middleware#136
Merged
sjs994 merged 1 commit intoNov 14, 2022
Merged
Conversation
54fb4fd to
75d6a5a
Compare
sjs994
approved these changes
Jun 23, 2022
e18326e to
3b9fe99
Compare
7c4793c to
76eced6
Compare
|
Bump on this pr? |
This commit changes the FastAPI middleware so that the `"route"` info is now optional. If it is not present, the SQL comment will not have the controller/route info. This info is always present in FastAPI routes. However, Starlette-based routes (FastAPI can mount Starlette apps as sub-applications) do not and would crash when the middleware tried to extract the information. Fixes google#133
76eced6 to
484494b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the FastAPI middleware so that the
"route"info isnow optional. If it is not present, the SQL comment will not have the
controller/route info.
This info is always present in FastAPI routes. However, Starlette-based
routes (FastAPI can mount Starlette apps as sub-applications) do not and
would crash when the middleware tried to extract the information.
Fixes #133