This repository was archived by the owner on May 29, 2026. It is now read-only.
Use async hooks from node, fix route comment#53
Merged
Merged
Conversation
Contributor
|
@aabmass for review. |
Member
|
I'm not super familiar with async hooks, but code makes sense to me. @omirho, were you able to verify it's working manually? |
|
Based on NodeJS docs, they suggest to use AsyncLocalStorage, rather than creating your own implementation on top async-hooks. Though this is only available from 12.17. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24.