Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

fix: Modify ConvertExceptionCallable to retry on Goaway #1588

Merged
gcf-merge-on-green merged 4 commits into from
Feb 7, 2023
Merged

fix: Modify ConvertExceptionCallable to retry on Goaway #1588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a784230
fix: Modify ConvertExceptionCallable to retry on Goaway
jackdingilian Jan 18, 2023
58641e9
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 2, 2023
40fbd5c
Merge branch 'main' into retry-on-goaway
jackdingilian Feb 2, 2023
7ae5c14
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,20 +49,20 @@ If you are using Maven without BOM, add this to your dependencies:
If you are using Gradle 5.x or later, add this to your dependencies:

```Groovy
implementation platform('com.google.cloud:libraries-bom:26.5.0')
implementation platform('com.google.cloud:libraries-bom:26.6.0')

implementation 'com.google.cloud:google-cloud-bigtable'
```
If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-bigtable:2.18.3'
implementation 'com.google.cloud:google-cloud-bigtable:2.18.4'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-bigtable" % "2.18.3"
libraryDependencies += "com.google.cloud" % "google-cloud-bigtable" % "2.18.4"
```

## Authentication
Expand Down
28 changes: 22 additions & 6 deletions ...gtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/ConvertExceptionCallable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.google.api.gax.rpc.ResponseObserver;
import com.google.api.gax.rpc.ServerStreamingCallable;
import com.google.api.gax.rpc.StreamController;
import com.google.common.base.Throwables;

/**
* This callable converts the "Received rst stream" exception into a retryable {@link ApiException}.
Expand Down Expand Up @@ -73,14 +74,29 @@ protected void onCompleteImpl() {
}

private Throwable convertException(Throwable t) {
// Long lived connections sometimes are disconnected via an RST frame. This error is
// transient and should be retried.
// Long lived connections sometimes are disconnected via an RST frame or a goaway. These errors
// are transient and should be retried.
if (isRstStreamError(t) || isGoAway(t)) {
return new InternalException(t, ((InternalException) t).getStatusCode(), true);
}
return t;
}

private boolean isRstStreamError(Throwable t) {
if (t instanceof InternalException && t.getMessage() != null) {
String error = t.getMessage().toLowerCase();
if (error.contains("rst_stream") || error.contains("rst stream")) {
return new InternalException(t, ((InternalException) t).getStatusCode(), true);
}
return error.contains("rst_stream") || error.contains("rst stream");
}
return t;
return false;
}

private boolean isGoAway(Throwable t) {
if (t instanceof InternalException) {
Throwable rootCause = Throwables.getRootCause(t);
String rootCauseMessage = rootCause.getMessage();
return rootCauseMessage != null
&& rootCauseMessage.contains("Stream closed before write could take place");
}
return false;
}
}