Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

chore: remove enforce-declared-grpc-and-proto-version enforcer check#1706

Merged
gcf-merge-on-green[bot] merged 4 commits into
googleapis:mainfrom
kolea2:renovate-protobuf
Apr 12, 2023
Merged

chore: remove enforce-declared-grpc-and-proto-version enforcer check#1706
gcf-merge-on-green[bot] merged 4 commits into
googleapis:mainfrom
kolea2:renovate-protobuf

Conversation

@kolea2
Copy link
Copy Markdown
Contributor

@kolea2 kolea2 commented Apr 12, 2023

No description provided.

@kolea2 kolea2 requested review from a team April 12, 2023 14:26
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Apr 12, 2023
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • renovate.json

@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Apr 12, 2023
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Apr 12, 2023
@kolea2 kolea2 changed the title chore: remove protoc from renovate config chore: remove enforce-declared-grpc-and-proto-version enforcer check Apr 12, 2023
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2023
@kolea2 kolea2 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 12, 2023
Copy link
Copy Markdown
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we arent trying to keep a uniform version, can you rename the properties?

protoc.version -> test-protoc.version
grpc.version -> test-protoc-grpc.version
protobuf.version -> test-protoc-protobuf.version

@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2023
@kolea2
Copy link
Copy Markdown
Contributor Author

kolea2 commented Apr 12, 2023

Now that we arent trying to keep a uniform version, can you rename the properties?

protoc.version -> test-protoc.version grpc.version -> test-protoc-grpc.version protobuf.version -> test-protoc-protobuf.version

@igorbernstein2 done, PTAL

Comment thread google-cloud-bigtable/pom.xml Outdated
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2023
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 6412d73 into googleapis:main Apr 12, 2023
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants