Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

feat: add experimental support for reverse scans public preview#1708

Closed
igorbernstein2 wants to merge 2 commits into
mainfrom
rev-scans-public
Closed

feat: add experimental support for reverse scans public preview#1708
igorbernstein2 wants to merge 2 commits into
mainfrom
rev-scans-public

Conversation

@igorbernstein2
Copy link
Copy Markdown
Contributor

@igorbernstein2 igorbernstein2 commented Apr 13, 2023 •
edited
Loading

This adds a reversed boolean to Query, which will allow endusers to stream rows in reverse order.

Example:

Query query = Query.create("alphabet").range("a", "z").limit(3);
ServerStream<Row> results = client.readRows(query);

for (Row row : results) {
  System.out.println(row.getKey().toStringUtf8());
}
// Prints z, y, x

This its currently blocked on generated protos which will be autogenerated soon

@igorbernstein2
feat: add experimental support for reverse scans public preview
a261d5e 
Change-Id: I092f236658a93a8ebd0bbc3bf1ef83c5c4978432
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Apr 13, 2023
@igorbernstein2
Add sample
d7f9ced 
Change-Id: I1f965e0f43fd3713a7abfff68466be7c861d08a7
mutianf
mutianf approved these changes Apr 13, 2023
View reviewed changes
Comment thread samples/snippets/src/main/java/com/example/bigtable/Reads.java
.limit(2)
.prefix("phone#4c410523")
.range(ByteStringRange.unbounded()
.startClosed("phone#5c10102")
Copy link
Copy Markdown
Contributor

@mutianf mutianf Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startClosed and end closed is the same key, maybe change to different keys? So customers can know if start key should be < end key or > end key because it's reversed?

Copy link
Copy Markdown
Contributor

@mutianf mutianf Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe in the javadoc example in Query.java update it to:

   * <pre>{@code
   * query
   *   .range(ByteStringRange.unbounded().startKeyClosed("a").endOpen("c"))
   *   .limit(10)
   *   .reversed(true)
   * }</pre>

Copy link
Copy Markdown
Contributor Author

@igorbernstein2 igorbernstein2 Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the sample to use different keys

Copy link
Copy Markdown
Contributor Author

@igorbernstein2 igorbernstein2 Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(in #1711)

@igorbernstein2
Copy link
Copy Markdown
Contributor Author

igorbernstein2 commented Apr 14, 2023 •
edited
Loading

closing in favor of #1711 and will address feedback there

mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request May 3, 2023
@gcf-owl-bot
chore: use gcp-docuploader 0.6.3 (googleapis#1708) (googleapis#1511)
e60c974 
Source-Link: googleapis/synthtool@fbc8bfe
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:e76136cc48f90aa19ba29cdfbd4002111467e44a1c9d905867d98dafafbd03bb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mutianf mutianf mutianf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@igorbernstein2 @mutianf